Skip to content

feat: Improve runtime metric dashboard templates#2092

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
drew/improve-runtime-templates
Apr 16, 2026
Merged

feat: Improve runtime metric dashboard templates#2092
kodiakhq[bot] merged 2 commits into
mainfrom
drew/improve-runtime-templates

Conversation

@pulpdrew
Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew commented Apr 10, 2026 •
edited
Loading

Summary

This PR improves the OTel Runtime Metric dashboard templates

  • Python template has been added
  • The filter condition on each template has been converted to Lucene so that it works with JSON schema in addition to the map schema
  • The top row of tiles have been increased to height: 4

Screenshots or video

Screenshot 2026-04-16 at 7 06 04 AM Screenshot 2026-04-16 at 7 06 43 AM Screenshot 2026-04-16 at 7 06 33 AM Screenshot 2026-04-16 at 7 06 23 AM Screenshot 2026-04-16 at 7 07 28 AM

How to test locally or on Vercel

These templates can be tested in the demo / preview environment.

References

  • Linear Issue: Closes HDX-3873
  • Related PRs:

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 16, 2026 3:53pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 32355a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 133 passed • 3 skipped • 1070s

Status Count
✅ Passed 133
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew force-pushed the drew/improve-runtime-templates branch from b080997 to d593035 Compare April 16, 2026 10:44
@pulpdrew pulpdrew force-pushed the drew/improve-runtime-templates branch from d593035 to db181fb Compare April 16, 2026 11:13
@pulpdrew pulpdrew marked this pull request as ready for review April 16, 2026 11:13
@github-actions github-actions Bot added the review/tier-3 Standard — full human review required label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026 •
edited
Loading

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats
  • Production files changed: 6
  • Production lines changed: 442
  • Branch: drew/improve-runtime-templates
  • Author: pulpdrew

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026 •
edited
Loading

PR Review

  • ⚠️ Missing trailing newlines on all 5 modified/added JSON files (dotnet-runtime.json, go-runtime.json, jvm-runtime-metrics.json, nodejs-runtime.json, python-runtime.json) → Add a trailing newline to each file (the diff shows \ No newline at end of file for all of them, and the existing files previously had newlines that this PR removes)

  • ⚠️ Spurious empty groupBy: "" in python-runtime.json tile 50a6fb (line 274, "CPU Seconds Used") — no other tile in this file or the other templates uses an empty groupBy field → Remove the field or set a meaningful value

  • ✅ SQL→Lucene filter migration is consistent across all templates and the python sourceMetricType: "gauge" matches the nodejs template pattern

@pulpdrew pulpdrew force-pushed the drew/improve-runtime-templates branch from db181fb to e214682 Compare April 16, 2026 11:43
@pulpdrew pulpdrew requested review from a team and knudtty and removed request for a team April 16, 2026 11:59
@knudtty
Copy link
Copy Markdown
Contributor

knudtty commented Apr 16, 2026

Looks great! The only thing I see is that the "GC Collections" number on this 1 day query is very large and doesn't fit properly in the box.
image

@kodiakhq kodiakhq Bot merged commit 5149fab into main Apr 16, 2026
18 checks passed
@kodiakhq kodiakhq Bot deleted the drew/improve-runtime-templates branch April 16, 2026 16:00
Copilot AI pushed a commit that referenced this pull request Apr 20, 2026
@pulpdrew @peter-leonov-ch
feat: Improve runtime metric dashboard templates (#2092)
eddceb5 
## Summary

This PR improves the OTel Runtime Metric dashboard templates

- Python template has been added
- The filter condition on each template has been converted to Lucene so that it works with JSON schema in addition to the map schema
- The top row of tiles have been increased to height: 4

### Screenshots or video

<img width="1472" height="891" alt="Screenshot 2026-04-16 at 7 06 04 AM" src="https://github.com/user-attachments/assets/da3c408f-512e-4c7d-a634-26eef6c02002" />
<img width="1476" height="903" alt="Screenshot 2026-04-16 at 7 06 43 AM" src="https://github.com/user-attachments/assets/13e599f2-0e0c-4bf3-b256-361b5ca29ea4" />
<img width="1475" height="906" alt="Screenshot 2026-04-16 at 7 06 33 AM" src="https://github.com/user-attachments/assets/0666c8cf-b176-47c1-8e9e-91637913bccf" />
<img width="1474" height="897" alt="Screenshot 2026-04-16 at 7 06 23 AM" src="https://github.com/user-attachments/assets/91d96561-ec1d-4720-ba37-dcbed9492f47" />
<img width="1478" height="901" alt="Screenshot 2026-04-16 at 7 07 28 AM" src="https://github.com/user-attachments/assets/f2aeea86-300d-4e31-90b9-ee50e6f0821a" />

### How to test locally or on Vercel

These templates can be tested in the demo / preview environment.

### References



- Linear Issue: Closes HDX-3873
- Related PRs:
Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knudtty knudtty knudtty approved these changes

Assignees

No one assigned

Labels

automerge review/tier-3 Standard — full human review required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pulpdrew @knudtty